Skip to content

The check for trends, comparing new point to average#864

Merged
Barthelemy merged 2 commits into
AliceO2Group:masterfrom
lauraser:ForPilot1D3Sigma
Oct 6, 2021
Merged

The check for trends, comparing new point to average#864
Barthelemy merged 2 commits into
AliceO2Group:masterfrom
lauraser:ForPilot1D3Sigma

Conversation

@lauraser
Copy link
Copy Markdown
Contributor

@lauraser lauraser commented Oct 5, 2021

The following check is performed on all trends currently available in the QC. The medium quality applied for >3sigma deviations, bad quality for >6sigma deviations.

@lauraser lauraser requested a review from wiechula as a code owner October 5, 2021 13:57
Comment thread Modules/TPC/src/CheckOfTrendings.cxx Outdated
#include <vector>
#include <numeric>

using namespace std;
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use this and std:: where needed. You do it in most places anyhow.

Suggested change
using namespace std;

@wiechula
Copy link
Copy Markdown
Collaborator

wiechula commented Oct 6, 2021

I think the macos failures are again unrelated

@wiechula
Copy link
Copy Markdown
Collaborator

wiechula commented Oct 6, 2021

@Barthelemy , can this be merged?

@Barthelemy
Copy link
Copy Markdown
Collaborator

yes. just trying to fix the mac build at the same time. I fixed a conflict here.

@wiechula
Copy link
Copy Markdown
Collaborator

wiechula commented Oct 6, 2021

@Barthelemy , thanks! I didn't spot this.

@Barthelemy Barthelemy merged commit 75e91c9 into AliceO2Group:master Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants